feat: tracking boolean operations #2153
Conversation
This PR contains the following changes - Client side change for boolean to remove delete on the python side (now done in the SC API) and update from response - Changes to add and delete body logic for proper dealing with @cached_property implementation of the function that get bodies - Small refactoring to avoid multiple definition of the function _serialize_tracker_command_response
|
This PR needs an update of Core Service code before it can be merged |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2153 +/- ##
==========================================
- Coverage 94.81% 94.63% -0.19%
==========================================
Files 141 141
Lines 10404 10431 +27
==========================================
+ Hits 9865 9871 +6
- Misses 539 560 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RobPasMue
changed the title
| @@ -494,7 +494,7 @@ def find_and_fix_extra_edges(self, **kwargs) -> dict: # noqa: D102 | |||
| # Call the gRPC service | |||
| response = self.stub.FindAndFixExtraEdges(request) | |||
|
|
|||
| serialized_tracker_response = self._serialize_tracker_command_response( | |||
| serialized_tracker_response = kwargs["parent_design"]._serialize_tracker_command_response( | |||
There was a problem hiding this comment.
I believe we should align the method used - there is one serialization method as part of this module too. If either one or the other is redundant, we should remove it.
| @@ -1045,6 +1045,55 @@ def __repr__(self) -> str: | |||
| lines.append(f" N Design Points : {len(self.design_points)}") | |||
| return "\n".join(lines) | |||
|
|
|||
| def _serialize_tracker_command_response(self, response) -> dict: | |||
There was a problem hiding this comment.
It should live inside the "_grpc" layer since it is purely related to the serialization of gRPC responses
|
@jacobrkerstetter @smereu -- tracker tests are still failing (although it might be related to my last comment #2153 (comment)) Make sure they pass again as part of this PR since we are dealing with the tracker directly. |
Description
This pull request contains the following changes
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist
feat: extrude circle to cylinder)